This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Take inherited fields into account. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support boxing and unboxing of primitives, we can use the original definitions instead of patching them.
This will make sure that we do not confuse static and non-static methods with the same signatures.
In `LinkedClass`es, the `fields` only list fields declared directly in the given class. When allocating Wasm structs and computing indices, we must take inherited fields into account as well.
tanishiking
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Looking at 8746b6b it looks good to me, thank you for fixing this!
| // Sort for stability | ||
| val sortedClasses = onlyModule.classDefs.sortBy(_.className) | ||
| /* Sort by ancestor count so that superclasses always appear before | ||
| * subclasses, then tie-break by name for stability. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
LinkedClasses, thefieldsonly list fields declared directly in the given class. When allocating Wasm structs and computing indices, we must take inherited fields into account as well.Based on #21.