Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update debian and rpm packages, rockspec #124

Closed
oleg-jukovec opened this issue Jul 22, 2022 · 2 comments · Fixed by #127
Closed

Update debian and rpm packages, rockspec #124

oleg-jukovec opened this issue Jul 22, 2022 · 2 comments · Fixed by #127
Assignees

Comments

@oleg-jukovec
Copy link
Contributor

oleg-jukovec commented Jul 22, 2022

Recipes for a build of .deb and .rpm packages look outdated. It is impossible to build packages without changes under CentOS 7 and Ubuntu 22.04. We need to check the build of this packages for target platforms and fix it.

Ubuntu 22.04 + debian

$ dpkg-buildpackage -us -uc
...
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 dpkg-source -b .
dpkg-source: error: can't build with source format '3.0 (quilt)': no upstream tarball found at ../tarantool-expirationd_1.0.0.1.orig.tar.{bz2,gz,lzma,xz}
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255

and

make[1]: Entering directory '/home/ozi/src/git/expirationd'
luatest -v --coverage --shuffle all:7412
/usr/bin/bash: line 1: luatest: command not found
make[1]: *** [Makefile:36: test] Error 127
make[1]: Leaving directory '/home/ozi/src/git/expirationd'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:4: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

workaround:

diff --git a/debian/changelog b/debian/changelog
index 7852052..bdc98f0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-tarantool-expirationd (1.0.0-1) unstable; urgency=medium
+tarantool-expirationd (1.0.0.1) unstable; urgency=medium
 
   * Initial release
 
diff --git a/debian/source/format b/debian/source/format
index 163aaf8..89ae9db 100644
--- a/debian/source/format
+++ b/debian/source/format
@@ -1 +1 @@
-3.0 (quilt)
+3.0 (native)

and to add a luatest location into PATH

CentOS7 + rpm

+ make test
make[1]: Entering directory '/build/usr/src/debug/tarantool-expirationd-1.2.3~beta1'
make[1]: which: Command not found
make[1]: -c: Command not found
luatest -v --coverage --shuffle all:
make[1]: -c: Command not found

workaround:
to add a luatest location into PATH

Related to #43

@oleg-jukovec oleg-jukovec changed the title Recheck the status of debian and rpm packages Recheck a status of debian and rpm packages Jul 22, 2022
@oleg-jukovec oleg-jukovec changed the title Recheck a status of debian and rpm packages Update debian and rpm packages Jul 22, 2022
@oleg-jukovec
Copy link
Contributor Author

oleg-jukovec commented Jul 27, 2022

Also dependency on tarantool-checks is missed. It may be usefull:

--- a/rpm/tarantool-expirationd.spec
+++ b/rpm/tarantool-expirationd.spec
@@ -8,8 +8,10 @@ URL: https://github.com/tarantool/tarantool-expirationd
 Source0: https://github.com/tarantool/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
 BuildArch: noarch
 BuildRequires: tarantool >= 1.6.8.0
+BuildRequires: tarantool-checks >= 3.1
 BuildRequires: /usr/bin/prove
 Requires: tarantool >= 1.6.8.0
+Requires: tarantool-checks >= 3.1
 %description
 This package can turn Tarantool into a persistent memcache replacement,
 but is powerful enough so that your own expiration strategy can be defined.

@oleg-jukovec
Copy link
Contributor Author

oleg-jukovec commented Jul 27, 2022

Also we can rewrite checks requirement:

"checks == 3.1.0-1",

like this:

checks >= 2.0, < 4

see https://github.com/luarocks/luarocks/wiki/Rockspec-format#dependency-information

@oleg-jukovec oleg-jukovec self-assigned this Jul 29, 2022
@oleg-jukovec oleg-jukovec changed the title Update debian and rpm packages Update debian and rpm packages, rockspec Jul 29, 2022
oleg-jukovec added a commit that referenced this issue Aug 1, 2022
The patch adds tarantool-checks runtime dependency for rpm/dep
packages. It also decreases required tarantool-check version to 2.1
because we because we are compatible with it in fact.

Part of #124
oleg-jukovec added a commit that referenced this issue Aug 1, 2022
We don't have the tarantool-luatest package in any public repository
for all supported distros. We have to skip the test step until the
tarantool-luatest is built at least for S3 repository.

Closes #124
oleg-jukovec added a commit that referenced this issue Aug 1, 2022
The patch adds tarantool-checks runtime dependency for rpm/dep
packages. It also decreases required tarantool-check version to 2.1
because we are compatible with it in fact.

Part of #124
oleg-jukovec added a commit that referenced this issue Aug 1, 2022
We don't have the tarantool-luatest package in any public repository
for all supported distros. We have to skip the test step until the
tarantool-luatest is built at least for S3 repository.

Closes #124
oleg-jukovec added a commit that referenced this issue Aug 3, 2022
The patch adds tarantool-checks runtime dependency for rpm/dep
packages. It also decreases required tarantool-check version to 2.1
because we are compatible with it in fact.

Part of #124
oleg-jukovec added a commit that referenced this issue Aug 4, 2022
Overview

    This release adds a Tarantool Cartridge role for expirationd
    package and improves the default behavior.

Breaking changes

    None.

New features

    Continue a task from a last tuple (#54).

    Decrease tarantool-checks dependency from 3.1 to 2.1 (#124).

    Process a task on a writable space by default (#42).

    Wait until a space or an index is created (#68, #116).

    Tarantool Cartridge role (#107).

Bugfixes

    Fix build and installation of rpm/deb packages (#124).

    Do not restart work fiber if index does not exist (#64).

    Update changelogs for rpm/deb packages.

Testing

    Shuffle tests (#118).

    Fix test_mvcc_vinyl_tx_conflict (#104, #105).

    Fix flaky 'simple expires test' (#90).

Other

    Add GitHub Actions workflow with debug Tarantool build (#102).

    Add GitHub Actions workflow for deploying module packages to S3
    based repositories (#43).
oleg-jukovec added a commit that referenced this issue Aug 4, 2022
Overview

    This release adds a Tarantool Cartridge role for expirationd
    package and improves the default behavior.

Breaking changes

    None.

New features

    Continue a task from a last tuple (#54).

    Decrease tarantool-checks dependency from 3.1 to 2.1 (#124).

    Process a task on a writable space by default (#42).

    Wait until a space or an index is created (#68, #116).

    Tarantool Cartridge role (#107).

Bugfixes

    Fix build and installation of rpm/deb packages (#124).

    Do not restart a work fiber if an index does not exist (#64).

    Update changelogs for rpm/deb packages.

Testing

    Shuffle tests (#118).

    Fix test_mvcc_vinyl_tx_conflict (#104, #105).

    Fix flaky 'simple expires test' (#90).

Other

    Add GitHub Actions workflow with debug Tarantool build (#102).

    Add GitHub Actions workflow for deploying module packages to S3
    based repositories (#43).
oleg-jukovec added a commit that referenced this issue Aug 5, 2022
Overview

    This release adds a Tarantool Cartridge role for expirationd
    package and improves the default behavior.

Breaking changes

    None.

Deprecated

    Obsolete functions: task_stats, kill_task, get_task, get_tasks, run_task,
    show_task_list.

New features

    Continue a task from a last tuple (#54).

    Decrease tarantool-checks dependency from 3.1 to 2.1 (#124).

    Process a task on a writable space by default (#42).

    Wait until a space or an index is created (#68, #116).

    Tarantool Cartridge role (#107).

Bugfixes

    Fix build and installation of rpm/deb packages (#124).

    Do not restart a work fiber if an index does not exist (#64).

    Update changelogs for rpm/deb packages.

Testing

    Shuffle tests (#118).

    Fix test_mvcc_vinyl_tx_conflict (#104, #105).

    Fix flaky 'simple expires test' (#90).

Other

    Add GitHub Actions workflow with debug Tarantool build (#102).

    Add GitHub Actions workflow for deploying module packages to S3
    based repositories (#43).
oleg-jukovec added a commit that referenced this issue Aug 11, 2022
Overview

    This release adds a Tarantool Cartridge role for expirationd
    package and improves the default behavior.

Breaking changes

    None.

Deprecated

    Obsolete functions: task_stats, kill_task, get_task, get_tasks, run_task,
    show_task_list.

New features

    Continue a task from a last tuple (#54).

    Decrease tarantool-checks dependency from 3.1 to 2.1 (#124).

    Process a task on a writable space by default (#42).

    Wait until a space or an index is created (#68, #116).

    Tarantool Cartridge role (#107).

Bugfixes

    Fix build and installation of rpm/deb packages (#124).

    Do not restart a work fiber if an index does not exist (#64).

    Update changelogs for rpm/deb packages.

Testing

    Shuffle tests (#118).

    Fix test_mvcc_vinyl_tx_conflict (#104, #105).

    Fix flaky 'simple expires test' (#90).

Other

    expirationd.start() parameter `space_id` has been renamed to
    `space` (#112).

    Add GitHub Actions workflow with debug Tarantool build (#102).

    Add GitHub Actions workflow for deploying module packages to S3
    based repositories (#43).
oleg-jukovec added a commit that referenced this issue Aug 11, 2022
Overview

    This release adds a Tarantool Cartridge role for expirationd
    package and improves the default behavior.

Breaking changes

    None.

Deprecated

    Obsolete functions: task_stats, kill_task, get_task, get_tasks, run_task,
    show_task_list.

New features

    Continue a task from a last tuple (#54).

    Decrease tarantool-checks dependency from 3.1 to 2.1 (#124).

    Process a task on a writable space by default (#42).

    Wait until a space or an index is created (#68, #116).

    Tarantool Cartridge role (#107).

Bugfixes

    Fix build and installation of rpm/deb packages (#124).

    Do not restart a work fiber if an index does not exist (#64).

    Update changelogs for rpm/deb packages.

Testing

    Shuffle tests (#118).

    Fix test_mvcc_vinyl_tx_conflict (#104, #105).

    Fix flaky 'simple expires test' (#90).

Other

    expirationd.start() parameter `space_id` has been renamed to
    `space` (#112).

    Add GitHub Actions workflow with debug Tarantool build (#102).

    Add GitHub Actions workflow for deploying module packages to S3
    based repositories (#43).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant