Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add linter(luacheck) into ci #57

Closed
ArtDu opened this issue Jun 1, 2021 · 0 comments · Fixed by #62
Closed

Add linter(luacheck) into ci #57

ArtDu opened this issue Jun 1, 2021 · 0 comments · Fixed by #62
Labels

Comments

@ArtDu
Copy link
Contributor

ArtDu commented Jun 1, 2021

No description provided.

@ArtDu ArtDu mentioned this issue Jun 1, 2021
@Totktonada Totktonada added the ci label Jun 7, 2021
@ligurio ligurio closed this as completed in 53b25ea Jul 6, 2021
ligurio added a commit that referenced this issue Jul 6, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1.
https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
ligurio added a commit that referenced this issue Jul 6, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1.
https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
@ligurio ligurio reopened this Jul 6, 2021
ligurio added a commit that referenced this issue Jul 6, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
ligurio added a commit that referenced this issue Jul 7, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
ligurio added a commit that referenced this issue Jul 7, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
ligurio added a commit that referenced this issue Sep 22, 2021
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. #61

Closes #57
ArtDu pushed a commit to ArtDu/expirationd that referenced this issue May 10, 2022
Added luacheck config and fixed a number of luacheck warnings.
Tarantool's Lua style guide allows to ignore some luacheck warnings [1].
File with TAP tests added to ignore list because we plan to rewrite
these tests to luatest style, see [2].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck
2. tarantool#61

Closes tarantool#57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants