Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wrong iterate_with function in tests #84

Closed
ligurio opened this issue Sep 27, 2021 · 0 comments · Fixed by #87
Closed

Wrong iterate_with function in tests #84

ligurio opened this issue Sep 27, 2021 · 0 comments · Fixed by #87
Labels
code health Improve code readability, simplify maintenance and so on tests

Comments

@ligurio
Copy link
Member

ligurio commented Sep 27, 2021

Tests for iterate_with uses wrong implementation of iterate_with function. It must return an iterator but it always returns true:

test/helper.lua

function helpers.is_expired_true()
    return true
end
@ligurio ligurio added the tests label Sep 27, 2021
@Totktonada Totktonada added the code health Improve code readability, simplify maintenance and so on label Oct 14, 2021
ligurio added a commit that referenced this issue Oct 15, 2021
@ligurio
test: make iterate_with() conform to declared interface
33f3996 
According to expirationd documentation user's function iterate_with must
accept task object and return an iterator. Patch fixes iterate_with
function defined for testing needs.

Closes #84
@ligurio ligurio mentioned this issue Oct 15, 2021
Merged
ligurio added a commit that referenced this issue Oct 15, 2021
@ligurio
test: make iterate_with() conform to declared interface
5e93c6e 
According to expirationd documentation user's function iterate_with must
accept task object and return an iterator. Patch fixes iterate_with
function defined for testing needs.

Closes #84
ligurio added a commit that referenced this issue Oct 15, 2021
@ligurio
test: make iterate_with() conform to declared interface
82d6106 
According to expirationd documentation user's function iterate_with must
accept task object and return an iterator. Add a function with such
interface and use it in a test for iterate_with.

Closes #84
ligurio added a commit that referenced this issue Oct 15, 2021
@ligurio
test: make iterate_with() conform to declared interface
3fcf04a 
According to expirationd documentation user's function iterate_with must
accept task object and return an iterator. Add a function with such
interface and use it in a test for iterate_with.

Closes #84
ArtDu pushed a commit to ArtDu/expirationd that referenced this issue May 10, 2022
@ligurio @ArtDu
test: make iterate_with() conform to declared interface
2b86786 
According to expirationd documentation user's function iterate_with must
accept task object and return an iterator. Add a function with such
interface and use it in a test for iterate_with.

Closes tarantool#84
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix iterate_with function in tests tarantool/expirationd
2 participants
@Totktonada @ligurio