-
Notifications
You must be signed in to change notification settings - Fork 60
test: fix compatibility with Tarantool master #295
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
New behavior: SELECT scan queries are only allowed if the SEQSCAN keyword is used correctly[1]. 1. https://www.tarantool.io/en/doc/latest/reference/reference_lua/compat/sql_seq_scan_default/ Related to tarantool/tarantool#8602
6d7579b
to
82a6f1d
Compare
query := "SELECT * FROM seqscan data;" | ||
if isSeqScanOld, err := test_helpers.IsTarantoolVersionLess(3, 0, 0); err != nil { | ||
t.Fatal("Could not check the Tarantool version") | ||
} else if isSeqScanOld { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, Seqscan was introduced in 2.11.0-rc1 (but it's not required by default), so you may use this condition too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea to test the default, which is 'old' for 2.11 and 'new` (with seqscan key word) in 3.0 and up.
b950746
to
82a6f1d
Compare
Overview New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
Overview The release introduces the ability to gracefully close Connection and ConnectionPool and also provides methods for adding or removing an endpoint from a ConnectionPool. Breaking changes There are no breaking changes in the release. New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
Overview The release introduces the ability to gracefully close Connection and ConnectionPool and also provides methods for adding or removing an endpoint from a ConnectionPool. Breaking changes There are no breaking changes in the release. New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
Overview The release introduces the ability to gracefully close Connection and ConnectionPool and also provides methods for adding or removing an endpoint from a ConnectionPool. Breaking changes There are no breaking changes in the release. New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
Overview The release introduces the ability to gracefully close Connection and ConnectionPool and also provides methods for adding or removing an endpoint from a ConnectionPool. Breaking changes There are no breaking changes in the release. New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
Overview The release introduces the ability to gracefully close Connection and ConnectionPool and also provides methods for adding or removing an endpoint from a ConnectionPool. Breaking changes There are no breaking changes in the release. New features Connection.CloseGraceful() unlike Connection.Close() waits for all requests to complete (#257). ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits for all requests to complete (#257). ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints from a pool (#290). Other Updates crud tests with Tarantool 3.0 (#293). Updates SQL tests with Tarantool 3.0 (#295).
New behavior: SELECT scan queries are only allowed if the SEQSCAN keyword is used correctly[1].
I didn't forget about (remove if it is not applicable):
Related issues:
tarantool/tarantool#8602