crud: support operation_data field in errors
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalt
force-pushed
the
askalt/gh-330-support-operation-data
branch
2 times, most recently
from
45514fc to
5cd7534
Compare
oleg-jukovec
approved these changes
Aug 22, 2023
askalt
force-pushed
the
askalt/gh-330-support-operation-data
branch
3 times, most recently
from
fb1345a to
adc116f
Compare
DerekBum
approved these changes
Aug 22, 2023
askalt
force-pushed
the
askalt/gh-330-support-operation-data
branch
from
adc116f to
7ce2007
Compare
This patch adds `operation_data` decoding for the `crud.Error`. The `operation_data` type is determined as `rowType` in `crud.Result`. Also, according to [1], an error can contain one of the following: - an error - an array of errors - nil So the error decoding logic has been modified to consider each case, in order to avoid comparing an error to nil. 1. https://github.com/tarantool/crud/tree/master#api Closes #330
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
operation_datadecoding for thecrud.Error.The
operation_datatype is determined asrowTypeincrud.Result.Also, according to [1], an error can contain one of the following:
So the error decoding logic has been modified to consider each case, in order to avoid comparing an error to nil.
I didn't forget about (remove if it is not applicable):
Closes #330