#389: add some logging for error of ConnectionPool.tryConnect #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Just few non-critical notes:
- Please, fix the review comment.
- Please, add the changelog entry here:
Line 12 in be0f71e
Something like this:
## Added
- Log messages if the pool unable to connect to an instance (#390)
- Please, squash commits into one commit and update the commit message. It could be something like:
pool: add log messages on connect error
I added some logging for ConnectionPool.tryConnect err result.
Part of #389
It will help us to have commits in the same style.
Add err log to ConnectionPool.Add() in case, when unable to establish connection and ctx is not canceled; also added logs for error case of ConnectionPool.tryConnect() calls in ConnectionPool.controller() and ConnectionPool.reconnect() Part of tarantool#389
Maximilan4
force-pushed
the
patch/389-logging
branch
from
457e2c9 to
dd01599
Compare
oleg-jukovec
approved these changes
Mar 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description at: #389
I added some logging for ConnectionPool.tryConnect err result.