Skip to content

pool: add missing methods to the pooler interface #395

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

KaymeKaydex
Copy link

added methods that are implemented but not included in the pooler interface

@oleg-jukovec oleg-jukovec requested a review from DerekBum May 1, 2024 10:06
Copy link

@DerekBum DerekBum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few non-critical notes:

  1. Please, fix the review comments in the same commit (git commit --amend + git push --force)
  2. Please, add the changelog entry after this line:
    `ConnectionPool.controller()` and `ConnectionPool.reconnect()`

Something like this:

## Added
- ...
- Methods that are implemented but not included in the pooler interface
  1. Please, update the commit message. It could be something like:
pool: add missing methods to the pooler interface

I added methods that are implemented but not included in the pooler interface.

It will help us to have commits in the same style.

@KaymeKaydex
Copy link
Author

KaymeKaydex commented May 6, 2024

@DerekBum , thanks for the review, I have corrected all, please check it again

@KaymeKaydex KaymeKaydex changed the title refactor pooler faces pool: add missing methods to the pooler interface May 6, 2024
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. Just a few non-critical notes.

Copy link

@DerekBum DerekBum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just a small doc comment, to make it more clear.
Thx for the patch!

I added methods that are implemented but not included in the pooler interface.
@oleg-jukovec oleg-jukovec merged commit 8b2be01 into tarantool:master May 7, 2024
21 checks passed
@oleg-jukovec oleg-jukovec mentioned this pull request Dec 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants