-
Notifications
You must be signed in to change notification settings - Fork 60
pool: add missing methods to the pooler interface #395
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few non-critical notes:
- Please, fix the review comments in the same commit (
git commit --amend
+git push --force
) - Please, add the changelog entry after this line:
Line 15 in c9ff313
`ConnectionPool.controller()` and `ConnectionPool.reconnect()`
Something like this:
## Added
- ...
- Methods that are implemented but not included in the pooler interface
- Please, update the commit message. It could be something like:
pool: add missing methods to the pooler interface
I added methods that are implemented but not included in the pooler interface.
It will help us to have commits in the same style.
c9ff313
to
f58a43d
Compare
@DerekBum , thanks for the review, I have corrected all, please check it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch. Just a few non-critical notes.
f58a43d
to
74b12c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Just a small doc comment, to make it more clear.
Thx for the patch!
I added methods that are implemented but not included in the pooler interface.
74b12c1
to
e7448fe
Compare
added methods that are implemented but not included in the pooler interface