Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for using arabic numerals to indicate fret number #47

Open
Aeyk opened this issue Dec 19, 2020 · 0 comments
Open

Support for using arabic numerals to indicate fret number #47

Aeyk opened this issue Dec 19, 2020 · 0 comments

Comments

@Aeyk
Copy link

Aeyk commented Dec 19, 2020

I notice that there is a commented out line to switch the numbering system form Roman Numerals to Arabic Numerals.

// var fret_labels = [ '', '1fr', '2fr', '3fr', '4fr', '5fr', '6fr', '7fr', '8fr', '9fr', '10fr', '11fr', '12fr', '13fr', '14fr', '15fr', '16fr', '17fr', '18fr', '19fr', '20fr', '21fr', '' ];

What would be needed for this to be a 'configurable option'? Something like a data-attribute on the #jtab element which could be read by jTab to decide which numbering system to use?

kurokky pushed a commit to kurokky/jtab that referenced this issue Jun 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant