Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add spectrum visualization notebook #2964

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KasukabeDefenceForce
Copy link
Contributor

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure
This PR aims at adding a spectrum visualization notebook which has some examples regarding how can someone plot the spectrum data.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Feb 3, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (723ce72).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

12	W293 	[*] Blank line contains whitespace
7	G004 	[ ] Logging statement uses f-string
6	W291 	[*] Trailing whitespace
4	E999 	[ ] SyntaxError: Expected a statement
1	TD005	[ ] Missing issue description after `TODO`

Complete output(might be large):

.github/workflows/lfs-cache.yml:1:12: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
.github/workflows/lfs-cache.yml:38:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:50:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:58:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:63:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:68:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:72:1: W293 [*] Blank line contains whitespace
docs/analysing_tardis_outputs/index.rst:1:1: E999 SyntaxError: Expected an expression
docs/analysing_tardis_outputs/index.rst:12:1: W293 [*] Blank line contains whitespace
docs/index.rst:1:1: E999 SyntaxError: Expected a statement
docs/index.rst:21:51: W291 [*] Trailing whitespace
docs/index.rst:43:76: W291 [*] Trailing whitespace
docs/index.rst:44:64: W291 [*] Trailing whitespace
docs/index.rst:45:71: W291 [*] Trailing whitespace
docs/index.rst:46:69: W291 [*] Trailing whitespace
docs/index.rst:47:68: W291 [*] Trailing whitespace
docs/index.rst:66:1: W293 [*] Blank line contains whitespace
docs/index.rst:80:1: W293 [*] Blank line contains whitespace
docs/index.rst:89:1: W293 [*] Blank line contains whitespace
docs/index.rst:113:1: W293 [*] Blank line contains whitespace
docs/io/visualization/index.rst:1:1: E999 SyntaxError: Expected a statement
docs/io/visualization/index.rst:25:1: W293 [*] Blank line contains whitespace
tardis/workflows/simple_tardis_workflow.py:230:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:451:17: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:172:13: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:212:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:16:3: TD005 Missing issue description after `TODO`
tardis/workflows/v_inner_solver.py:180:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:207:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:315:17: G004 Logging statement uses f-string
Found 30 errors.
[*] 18 fixable with the `--fix` option.

@KasukabeDefenceForce KasukabeDefenceForce marked this pull request as ready for review February 4, 2025 14:09
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has failed

Click here to see the build log.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (34c0a4f) to head (723ce72).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   69.54%   69.17%   -0.37%     
==========================================
  Files         228      228              
  Lines       16429    16429              
==========================================
- Hits        11425    11365      -60     
- Misses       5004     5064      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants