Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disallow Merge Refs from Creating Cache #2965

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as ready for review February 3, 2025 15:22
@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (195d5d3).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

6	W293	[*] Blank line contains whitespace
1	E999	[ ] SyntaxError: Simple statements must be separated by newlines or semicolons

Complete output(might be large):

.github/workflows/lfs-cache.yml:1:12: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
.github/workflows/lfs-cache.yml:38:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:50:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:58:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:63:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:68:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:72:1: W293 [*] Blank line contains whitespace
Found 7 errors.
[*] 6 fixable with the `--fix` option.

@andrewfullard andrewfullard enabled auto-merge (squash) February 3, 2025 15:25
@andrewfullard andrewfullard merged commit 35c3190 into tardis-sn:master Feb 3, 2025
18 of 21 checks passed
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (34c0a4f) to head (195d5d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2965      +/-   ##
==========================================
- Coverage   69.54%   69.17%   -0.37%     
==========================================
  Files         228      228              
  Lines       16429    16429              
==========================================
- Hits        11425    11365      -60     
- Misses       5004     5064      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants