refactor(pause): stop run execution #3046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
refactor-pause-worker
branch
from
d2dedbd to
a7c8d1c
Compare
manast
reviewed
Feb 3, 2025
src/classes/worker.ts
Outdated
| @@ -476,6 +475,9 @@ export class Worker< | |||
| numTotal < this._concurrency && | |||
| (!this.limitUntil || numTotal == 0) | |||
| ) { | |||
| if (this.paused) { | |||
There was a problem hiding this comment.
This could be moved to the while loop condition expression instead.
| @@ -582,11 +584,7 @@ export class Worker< | |||
| { block = true }: GetNextJobOptions = {}, | |||
| ): Promise<Job<DataType, ResultType, NameType> | undefined> { | |||
| if (this.paused) { | |||
| if (block) { | |||
There was a problem hiding this comment.
There could be a reason why we block here, it could be that the loop will run super fast doing nothing consuming all the CPU, this needs to be properly tested.
I modified the test case to verify that runExecution is resolved after pausing |
roggervalf
force-pushed
the
refactor-pause-worker
branch
from
ec03b53 to
c36a209
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Notice that we wait for pending jobs in https://github.com/taskforcesh/bullmq/blob/master/src/classes/worker.ts#L954 when pausing a worker by default, but we can possibly add paused promise into async queue https://github.com/taskforcesh/bullmq/blob/master/src/classes/worker.ts#L586, that means that we can get pause method hanging