-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cherry pick DMG settings to 1.x #8334
Conversation
313f768
to
852bc57
Compare
abdc326
to
bbbc73b
Compare
This is now rebased and I have signed all the cherry-picked commits |
bbbc73b
to
da54ca8
Compare
da54ca8
to
b4fc683
Compare
i meant to approve the ci checks, not the pr itself lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why clippy is having a mental breakdown but i'll worry about that somewhere else, not in this PR.
Thanks again for the PR!
why was it rolled back:((? |
I just tested the latest version, but it seems that the changes did not take effect. The dmg I packaged looks like this: "dmg": {
"background": "images/background.png",
"appPosition": {
"x": 180,
"y": 170
},
"applicationFolderPosition": {
"x": 480,
"y": 170
},
"windowSize": {
"height": 400,
"width": 660
},
"windowPosition": {
"x": 200,
"y": 180
}
} I noticed that the default position for two icon in the original code were set like this, and it didn't work in previous versions either. I'm not sure where the issue lies. |
(I assume you used the CLI from git because it's not released yet?) Did you build the dmg in CI like GitHub actions? If so then this is a known issue and happened before this PR too. :/ |
What kind of change does this PR introduce?
Cherry pick from dev to 1.x
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information