Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core/dialog): reconstruct path using appropriate separator, closes #8074 #8408

Merged
merged 5 commits into from
Dec 19, 2023
Merged

fix(core/dialog): reconstruct path using appropriate separator, closes #8074 #8408

merged 5 commits into from
Dec 19, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 15, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner December 15, 2023 01:21
@amrbashir amrbashir changed the title fix(core/dialog): reconstruct path using appropraite separator, closes #8074 fix(core/dialog): reconstruct path using appropriate separator, closes #8074 Dec 15, 2023
@lucasfernog lucasfernog merged commit 50a3d17 into 1.x Dec 19, 2023
@lucasfernog lucasfernog deleted the fix/dialog/windows-froward-slash branch December 19, 2023 00:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog