Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cli): use matched_path_or_any_parents when checking if a file is ignored #8903

Merged
merged 5 commits into from
Mar 6, 2024
Merged

fix(cli): use matched_path_or_any_parents when checking if a file is ignored #8903

merged 5 commits into from
Mar 6, 2024

Conversation

anatawa12
Copy link
Contributor

Fixes #8901

@anatawa12 anatawa12 requested a review from a team as a code owner February 19, 2024 16:31
@anatawa12 anatawa12 force-pushed the taurignore-watch-folder branch from c34443f to 43795d6 Compare February 19, 2024 16:33
@anatawa12 anatawa12 force-pushed the taurignore-watch-folder branch from 43795d6 to 6695966 Compare February 19, 2024 16:51
@anatawa12 anatawa12 changed the base branch from dev to 1.x February 19, 2024 16:52
@anatawa12 anatawa12 marked this pull request as draft February 19, 2024 17:13
@anatawa12 anatawa12 marked this pull request as ready for review February 19, 2024 17:16
@amrbashir
Copy link
Member

Could you give an example of the .taurignore you're trying to fix?

@anatawa12
Copy link
Contributor Author

image

This taurignore should ignore changes in web folder from watching but doesn't. changes in .next folder will cause rebuilding whole app.

@amrbashir
Copy link
Member

amrbashir commented Mar 6, 2024 •
edited
Loading

@anatawa12 sorry for the long delay, I just tested the ignore file you posted and I didn't see any issues, all files were ignored except package.json

Would you mind providing a minimal repro?

@anatawa12
Copy link
Contributor Author

https://github.com/anatawa12/tauri-issue-8901 is the repository that I can reproduce this problem.

clone and run cargo tauri dev and then editing web/ignored/test file will cause rebuild of the crate.
image

amrbashir
amrbashir approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir changed the title fix(cli): taurignore ignoreing folders not working for watch fix(cli): use matched_path_or_any_parents when checking if a file is ignored Mar 6, 2024
@amrbashir amrbashir merged commit b15948b into tauri-apps:1.x Mar 6, 2024
10 checks passed
@anatawa12 anatawa12 deleted the taurignore-watch-folder branch March 6, 2024 19:19
amrbashir added a commit that referenced this pull request Apr 18, 2024
@FabianLars @amrbashir
@github-actions @lucasfernog @bifs @anatawa12 @jetli
chore: merge remote-tracking branch '1.x' into v2 (#9479)
e64b8f1 
* chore: port PR template from `dev` branch (#9004)

* fix(runtime-wry): avoid panic during clipboard initialization on wayland (#9003)

closes #8964

* ci: downgrade thread_local to 1.1.7 in msrv list (#9012)

* Apply Version Updates From Current Changes (v1) (#9013)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(bundler): escape potentially problematic strings in an XML (#9040)

* fix(bundler): escape potentially problematic strings in an XML (#9030)

- replace characters invalid in XML with their escaped form to properly bundle resources with such characters in their pathnames.

* change file

* fix(cli): use `matched_path_or_any_parents` when checking if a file is ignored (#8903)

* fix: taurignore ignoreing folders not working for watch

* docs: add to changes

* fix: panic: path is expected to be under the root

* Update taurignore-ignoring-folders-not-working-for-watch.md

* Update taurignore-ignoring-folders-not-working-for-watch.md

* fix(cli): migrate to stable features of `log` crate (#9119)

* fix(cli): migrate to stable features of `log` crate

* to_cow_str

* Apply Version Updates From Current Changes (v1) (#9074)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(core/path): remove suffix in basename only once (#9166)

* fix(core/path): remove suffix in basename only once

ref: #9064

* Update tooling/api/src/path.ts

---------

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* fix(cli): Clone Options struct after mutating it. (#9188)

* fix(bundler): Fix nsis resource paths on non-windows build systems. (#9281)

* fix(bundler): Fix nsis resource paths on non-windows build systems.

* remove leftover from alternative

* fix(bundler/nsis): Don't use /R flag on installation dir (#9282)

* fix(cli): upgrade heck to better support Chinese/Japanese prodcut name on Linux (#9298)

* chore: fix clippy false positive (#9329)

* fix(cli/info): fix crash when checking node version (#9411)

closes #9396

---------

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: bifs <127015052+bifs@users.noreply.github.com>
Co-authored-by: anatawa12 <anatawa12@icloud.com>
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] specifying folder to .taurignore doesn't exclude files in the folder for watching
2 participants
@anatawa12 @amrbashir