Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add WebViewBuilder.with_javascript_disabled #1496

Merged
merged 9 commits into from
Mar 2, 2025

Conversation

Simon-Laux
Copy link
Contributor

@Simon-Laux Simon-Laux commented Feb 23, 2025

add WebViewBuilder.with_javascript_disabled to disable javascript.

There are some cases where this is nessesary.
For example I need this for safely displaying HTML emails in delta chat:

closes #986 (which was only solved for windows before)

example to try out: https://github.com/Simon-Laux/tauri-experiments/tree/main/examples/disable_js_wry

Progress

  • MacOS (implemented and tested)
  • Windows (implemented and tested)
  • Linux (implemented and tested)
  • change wry import to git branch instead of local checkout in example
  • If this change requires a new version, then add a change file in .changes directory with the appropriate bump, see https://github.com/tauri-apps/wry/blob/dev/.changes/readme.md
  • Ensure that all commits are signed

@Simon-Laux Simon-Laux marked this pull request as ready for review February 23, 2025 08:05
@Simon-Laux Simon-Laux requested a review from a team as a code owner February 23, 2025 08:05
Copy link
Contributor

github-actions bot commented Feb 23, 2025

Package Changes Through b49b31c

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.50.2 0.50.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@lucasfernog lucasfernog merged commit 94ecadb into tauri-apps:dev Mar 2, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable javascript in webview
2 participants