Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --exact-names option to find_cards #81

Closed
wants to merge 2 commits into from
Closed

Conversation

fenhl
Copy link
Contributor

@fenhl fenhl commented May 2, 2018

This adds an --exact-names option to the find_cards script to disable card name normalization for better interoperability in scripting. This is required to start work on fenhl/magic-set-generator#9. It has been tested both with and without -v (which as a bonus is also available as --verbose now).

fenhl added 2 commits May 2, 2018 07:03
@taw
Copy link
Owner

taw commented May 2, 2018

The motivating factor for this step were the extremely obnoxious "Ae" ligatures.

Now the Ae ligatures are gone anyway, I'm not even sure why don't we just always display diacriticals. That affects basically a handful of old cards, and Seance.

(the matching itself should of course still ignore them)

Which cards are affected by this?

@taw
Copy link
Owner

taw commented May 2, 2018

Full list of affected cards is just these 25 (compared with 118 with AE):

  • Bösium Strip
  • Chicken à la King
  • Dandân
  • Déjà Vu
  • El-Hajjâj
  • Ghazbán Ogre
  • Ghazbán Ogress
  • Ifh-Bíff Efreet
  • Junún Efreet
  • Juzám Djinn
  • Jötun Grunt
  • Jötun Owl Keeper
  • Khabál Ghoul
  • Legions of Lim-Dûl
  • Lim-Dûl the Necromancer
  • Lim-Dûl's Cohort
  • Lim-Dûl's Hex
  • Lim-Dûl's High Guard
  • Lim-Dûl's Paladin
  • Lim-Dûl's Vault
  • Márton Stromgald
  • Oath of Lim-Dûl
  • Ring of Ma'rûf
  • Sauté
  • Séance

Definitely not worth the trouble of extra options, I'll just give them proper diacritics back.

@taw
Copy link
Owner

taw commented May 2, 2018

Name now keeps diacritics. Oracle and flavor text don't work consistently with diacritics (flavor keeps them, Oracle text doesn't), so I'll fix them too.

Need to check foreign names, artist names etc.

@fenhl
Copy link
Contributor Author

fenhl commented May 3, 2018

The downstream issue was fixed in 8ea785d. Leaving this open because of your last comment.

@taw
Copy link
Owner

taw commented May 3, 2018

Diacritics are now preserved in Oracle and flavor text as well.

For normal queries, it's normalized (stripped from query and text before match).
For regexp queries, it's not normalized, and it's probably better this way.

@taw
Copy link
Owner

taw commented May 3, 2018

Unless I missed something, we should probably close this.

@fenhl fenhl closed this May 3, 2018
@fenhl fenhl deleted the exact-names branch May 3, 2018 18:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants