Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Markup: New & better graphics, remove spec css element #3352

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Markup: New & better graphics, remove spec css element #3352

wants to merge 7 commits into from
+617 −715

Conversation

gesa
Copy link
Member

@gesa gesa commented Jun 13, 2024 •
edited
Loading

Do not merge until tc39/ecmarkup#600 is merged & updated.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Jun 17, 2024
syg
syg reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that print-front-cover.svg has the edition number and 2024 hard-coded. Is the plan that this needs to be manually updated every year? Is there a script to generate this?

@michaelficarra
Copy link
Member

@syg

Is the plan that this needs to be manually updated every year? Is there a script to generate this?

It's an SVG, it should be very easy to do this:

image

@gesa
Copy link
Member Author

gesa commented Jul 3, 2024

Alright cover will be automatically generated in the future, files live with ecmarkup.

@bakkot bakkot removed the editor call to be discussed in the next editor call label Nov 6, 2024
@michaelficarra michaelficarra marked this pull request as ready for review March 3, 2025 22:55
@bakkot bakkot added the editor call to be discussed in the next editor call label Mar 3, 2025
@bakkot
Copy link
Contributor

bakkot commented Mar 3, 2025

Should be ready, sorry for the delay @gesa. Unfortunately we don't have a copy of Prince so once this lands we'll need your help to confirm we didn't mess it up somehow.

@michaelficarra michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Mar 5, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@syg syg syg left review comments

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gesa @michaelficarra @bakkot @syg