Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Suppress line breaks before field/slot references #602

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

gibson042
Copy link
Contributor

I found an instance where a line break after the period in specAlias.[[SlotName]] made for confusing reading, making it look like a sentence was ending prematurely. This CSS change suppresses such line breaks by generating a non-copyable word joiner before each field/slot reference.

Before

Note the line break after "[[Block]] is buffer." and before the "[[ArrayBufferByteLengthData]]" that is connected to buffer:

screenshot (before change)

After

Note the line break moving to after "[[Block]] is" and before "buffer.[[ArrayBufferByteLengthData]]", keeping the latter together as a single unit:

screenshot (after change)

@gibson042 gibson042 requested a review from bakkot August 16, 2024 03:10
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gibson042 gibson042 force-pushed the 2024-08-pre-slot-line-breaks branch from 75a1497 to e335060 Compare August 16, 2024 19:11
@bakkot bakkot merged commit f5c2c45 into tc39:main Aug 16, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants