Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Reorder strict=true and privateScope to follow FunctionCreate signature #282

Closed
wants to merge 1 commit into from

Conversation

kevinkassimo
Copy link

Seems that the 2 are flipped in order. According to the spec:

3.9.4 FunctionCreate ( kind, ParameterList, Body, Scope, PrivateScope, Strict [ , prototype ] )

@nicolo-ribaudo
Copy link
Member

After tc39/ecma262#1562, all this part of the proposed text spec must be rewritten.

@kevinkassimo
Copy link
Author

@nicolo-ribaudo Is this proposal based on es6 spec or master of ecma262? Since I see quite a few es6num markers and spec in this repo uses steps exactly matching the former, which does include FunctionCreate instead of OrdinaryFunctionCreate

@littledan
Copy link
Member

@kevinkassimo This is based on the master of ecma262, though it's likely it got a bit stale. I'd welcome PRs to rebase.

@ljharb
Copy link
Member

ljharb commented Jan 7, 2020

If this repo is updated, please be sure to ensure that tc39/ecma262#1655, tc39/ecma262#1667, and tc39/ecma262#1668 are all updated as well.

@kevinkassimo
Copy link
Author

In that case I would close this PR. (I actually made an attempt to update fully, but there are still quite a few mismatching parts and I currently do not have the time to work on unfortunately...)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants