Normative: Reject non-integer Duration fields in Duration.with() #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 94.85% 91.08% -3.77%
==========================================
Files 19 17 -2
Lines 10882 10772 -110
Branches 1729 1606 -123
==========================================
- Hits 10322 9812 -510
- Misses 547 946 +399
- Partials 13 14 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljharb
requested changes
Aug 16, 2021
ptomato
force-pushed
the
1704-duration-with-noninteger
branch
from
73eb281 to
463a9f0
Compare
|
(Draft because normative PR waiting for consensus) |
ptomato
force-pushed
the
1704-duration-with-noninteger
branch
from
463a9f0 to
c85bedb
Compare
|
This change achieved consensus in TC39. Rebased and fixed some conflicts; @Ms2ger would you mind taking a final look? |
Ms2ger
approved these changes
Sep 2, 2021
…onRecord The test should be floor(abs(v)) == abs(v). Use the existing abstract operation. Adds an extra line to each test which should cover this as well.
Ms2ger
force-pushed
the
1704-duration-with-noninteger
branch
from
c85bedb to
b0b41d9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unintentionally forgot with() when rejecting non-integer Duration fields
in issue #938.
Adds tests for anywhere Duration property bags are accepted, fixes a test
that would fail under the new spec text, and brings the testing polyfill
code in alignment with the new spec text.
Closes: #1704