Integrate Intl.DurationFormat into Temporal #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
- Coverage 96.37% 96.14% -0.24%
==========================================
Files 21 21
Lines 9874 9928 +54
Branches 1800 1801 +1
==========================================
+ Hits 9516 9545 +29
- Misses 311 336 +25
Partials 47 47 ☔ View full report in Codecov by Sentry. |
ToIntegerIfIntegral no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move ToIntegerIfIntegral into ECMA-262. Remove it from abstractops.html and put it in an <ins> block in mainadditions.html, and in a <del> block in intl.html.
ToIntegerIfIntegral no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move ToIntegerIfIntegral into ECMA-262. Put it in a <del> block in intl.html. We can keep the new definition in its current place in the spec while adjusting its ID.
DurationSign no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move Duration#to ECMA-262. Put it in a <del> block in intl.html. We can keep the new definition in its current place in the spec while adjusting its ID. Once Temporal.Duration objects are introduced, there is no longer any need for Duration Records. So, make the ECMA-402 DurationSign accept a Temporal.Duration object (as it already did in Temporal), delete the ToDurationRecord operation and the Duration Record definition, and change several other operations from ECMA-402 to use Temporal.Duration objects instead of Duration Records. Temporarily, since these operations aren't yet in ecma402-biblio pending tc39/ecma402#943, add a JSON bibliography file so the references aren't dangling.
ptomato
force-pushed
the
452-integrate-durationformat
branch
from
0b11e62 to
2736777
Compare
ryzokuken
approved these changes
Feb 14, 2025
This operation had a placeholder note until the Intl.DurationFormat proposal would reach stage 4. Now that the proposal is stage 4, we can replace the placeholder note with the real implementation. Closes: #452
The previous implementation in the reference code was non-conformant on hosts with Intl.DurationFormat implemented without Temporal.Duration integration. On those hosts, the argument to format() would be treated as a Duration-like property bag and its properties would be observably read, even if it was a Temporal.Duration. The correct behaviour would be to get the information from the Temporal.Duration object's internal slots.
An additional modification to ECMA-402 that Temporal makes, is for DurationFormat.p.format and formatToParts to accept a Temporal.Duration object as input. This monkeypatches those methods to conform to that requirement.
ptomato
force-pushed
the
452-integrate-durationformat
branch
from
2736777 to
cf54568
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intl.DurationFormat is stage 4, so we can now incorporate the necessary changes to use it in Temporal.Duration.prototype.toLocaleString and to accept Temporal.Duration as an argument to Intl.DurationFormat.prototype.format and formatToParts. Some operations need to move from ECMA-402 into ECMA-262.
Closes: #452