Legacy date conversion #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042,
mattjohnsonpint and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
==========================================
- Coverage 93.93% 93.88% -0.05%
==========================================
Files 17 18 +1
Lines 5739 5743 +4
Branches 862 863 +1
==========================================
+ Hits 5391 5392 +1
- Misses 341 344 +3
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ryzokuken
approved these changes
Oct 5, 2020
|
There's a linter error that needs to be fixed. Also, should we rename |
This was forgotten in the rename.
It seems appropriate to do this, now that we have a round() method to demonstrate.
This is in response to feedback that this conversion should be less verbose. No unit tests currently included because I found out that the test code doesn't import the shim but instead imports individual objects from lib/temporal.mjs, and I didn't see a quick way to fix that. Anyway, the method is tested in the cookbook already. Closes: #515
As suggested in code review, this avoids confusion between different regional spellings.
ptomato
force-pushed
the
515-legacy-date-conversion
branch
from
a688745 to
94091a1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #515
Includes a few stragglers from the Absolute→Instant rename and from the addition of round(), that I noticed.