chore(deps): Remove unused dependencies

[WillGibson]

It occurred to me that we could reduced security risk by removing unused dependencies...

➜ npx depcheck       
Unused dependencies
* chalk
* commander
* needle
* proxy-agent
* xmlbuilder2

Some of those were false positives because, like Stryker, depcheck does not check markdown-link-check because it has no file extension.

[smainil]

I only found that xmlbuilder2 is not used in this project. The others are used https://github.com/tcort/markdown-link-check/blob/master/markdown-link-check

[WillGibson]

I will double check later.

I was running the following after removing each to check for no apparent change in behaviour...

rm -rf package-lock.json node_modules && npm install && npm run test && ./markdown-link-check --verbose --progress test

I think this is perhaps adding to the case for more comprehensive test coverage.

[smainil]

I just had a look to the package-lock.json and for example the removal of needle works because this package is also needed by the link-check dependency

markdown-link-check/package-lock.json

Line 2238 in cca7acb

"needle": "^3.3.1",

so it's installed and available for the markdown-link-check but if we stop using needle for link-check we'll don't have that package available anymore in the current project

[WillGibson]

I forgot about the extensionless markdown-link-check file and filtered by .js extension when searching the code 🙄

Probably should explicitly include needle as we use it directly. Same for proxy-agent.

I have restored them.

[smainil]

used in

markdown-link-check/eslint.config.mjs

Line 4 in f6bc588

export default [

but maybe it comes with the eslint import

[WillGibson]

Yes, that comes with eslint/eslintrc.

[nschonni]

markdown-link-check/eslint.config.mjs

Line 2 in f6bc588

import globals from "globals";

[WillGibson]

Comes as part of the @eslint/eslintrc dependencies.

[nschonni]

Used

markdown-link-check/eslint.config.mjs

Line 1 in f6bc588

import js from "@eslint/js";

[WillGibson]

It is included as part of the eslint dependencies.

[nschonni]

For now it is, but it's also recommended to separately install it as part of the docs https://eslint.org/docs/latest/use/getting-started#manual-set-up

[WillGibson]

OK, I've added that back.

[nschonni]

markdown-link-check/eslint.config.mjs

Line 2 in f6bc588

import globals from "globals";