-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(xUnitXmlPublisher): Include assertion message in test output #208
base: master
Are you sure you want to change the base?
feat(xUnitXmlPublisher): Include assertion message in test output #208
Conversation
55a1946
to
c4f6242
Compare
c4f6242
to
c7c8563
Compare
Maybe some explanation on how to verify this:
If any test fails, the C:\tcunit_xunit_testresults.xml will now correctly show the EXP and ACT values in the assertion message <testsuites disabled="" failures="116" tests="144" time="6.1428994">
<testsuite id="0" name="PRG_TEST.PrimitiveTypes" tests="46" failures="23" time="1.4893e-3">
<testcase name="Test_ANY_Equals" classname="PRG_TEST.PrimitiveTypes" time="2.35e-5" status="PASS" />
<testcase name="Test_ANY_Differ_DataType" classname="PRG_TEST.PrimitiveTypes" time="1.47e-5" status="FAIL">
<failure message="Values differ; EXP: (Type class = INT), ACT: (Type class = UINT)" type="Array2D_LREAL" />
</testcase>
<testcase name="Test_BOOL_Equals" classname="PRG_TEST.PrimitiveTypes" time="3.8e-6" status="PASS" />
<testcase name="Test_BOOL_Differ" classname="PRG_TEST.PrimitiveTypes" time="1.18e-5" status="FAIL">
<failure message="Values differ; EXP: TRUE, ACT: FALSE" type="Array2D_LREAL" />
</testcase>
<testcase name="Test_BYTE_Equals" classname="PRG_TEST.PrimitiveTypes" time="4.4e-6" status="PASS" />
<testcase name="Test_BYTE_Differ" classname="PRG_TEST.PrimitiveTypes" time="1.14e-5" status="FAIL">
<failure message="Values differ; EXP: 0xAB, ACT: 0xCD" type="Array2D_LREAL" />
</testcase> Without the PR, failure > message only shows "Values differ" |
@stefanbesler Have you noticed the problems described in #226? |
@stefanbesler thanks for this, it will be good to have these more granular results. |
@stefanbesler, Hi, I really want to have this feature. If I can help, please let me know |
I agree, this is a great feature. @dfreiberger & @TimSalzmann, you are of course welcome to help me figure out the problem! |
Realized that the discussion in this PR went very OffTopic, cleared it up. Sorry for that! @stefanbesler I'm working on the last pieces to release 1.3. After that, I will look into this PR. |
This PR write the actual assertion failure to the output of xUnitXmlPublisher. Previously only the message from test was written into message.
@dfreiberger fyi