-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add vo-list command #203
Add vo-list command #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastian-luna-valero thank very much for the PR. My first thought of fedcloud site vo-list
is about listing the VO supported on a given site. What about merging the new command which the fedcloud site list
command, i.e. fedcloud site list --vo VO
where if the --vo option is omitted, it will print all sites, if present, print only sites supported the VO.
PS. Sorry for unfinished comments, misclicking :-)
Thanks for your feedback @tdviet
That was my initial attempt, but I then realised that the
Therefore, adding it to the existing $ fedcloud site list
Usage: fedcloud site list [OPTIONS]
Try 'fedcloud site list --help' for help.
Error: Missing option '--vo'. That's why I created a new command. However, I agree the naming might be confusing. Instead, how should I call it to make it more intuitive? |
What about creating a new decorator for |
Done!
That was exactly my concern and I didn't test it. Seems to work well, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Initial checklist
Description of changes
Added a new command to filter sites in the EGI Federated Cloud supporting a VO