Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: set error cause if available #1649

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat: set error cause if available #1649

merged 1 commit into from
Aug 14, 2024

Conversation

arthurschreiber
Copy link
Collaborator

@arthurschreiber arthurschreiber commented Aug 11, 2024

This pull request updates ConnectionError and RequestError with support for a new options argumenton their constructor. This parameter mirrors the options of Error base class and allows setting a cause.

I updated all the locations where ConnectionError or RequestError are constructed to set the cause if available.

@arthurschreiber arthurschreiber changed the title feat: et error cause if available. feat: set error cause if available Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (03777a7) to head (dd628c1).
Report is 1 commits behind head on master.

Files Patch % Lines
src/request.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1649      +/-   ##
==========================================
+ Coverage   78.99%   79.11%   +0.12%     
==========================================
  Files          93       93              
  Lines        4879     4879              
  Branches      937      937              
==========================================
+ Hits         3854     3860       +6     
+ Misses        721      711      -10     
- Partials      304      308       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSun90 MichaelSun90 merged commit f405eab into master Aug 14, 2024
28 of 29 checks passed
Copy link

🎉 This PR is included in version 18.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants