Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add knative/pkg based TektonTrigger API and Reconciler #153

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Add knative/pkg based TektonTrigger API and Reconciler #153

merged 1 commit into from
Sep 25, 2020

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Sep 21, 2020 •
edited
Loading

Part of #150

Changes

  • Add TektonTrigger API

  • Add TektonTrigger API with spec

  • Add generated clients and deepcopy

  • Add generated clientset, informers, injection clients, and listers

  • Add generated deepcopy

/cc @nikhil-thomas

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 21, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 21, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/common.go Do not exist 0.0%
pkg/reconciler/common/deployments.go Do not exist 0.0%
pkg/reconciler/common/extensions.go Do not exist 100.0%
pkg/reconciler/common/install.go Do not exist 0.0%
pkg/reconciler/common/releases.go Do not exist 0.0%
pkg/reconciler/common/stages.go Do not exist 0.0%
pkg/reconciler/common/transformers.go Do not exist 0.0%

@nikhil-thomas
Copy link
Member

This looks good.

I have `question, should make the TektonTrigger reconciler respont to only on reosurce name(eg:

operator/pkg/reconciler/tektonpipeline/tektonpipeline.go

Line 96 in 7deb4ca

if tp.GetName() != watchedResourceName {
)

That will make sure that only one instance of triggers is installed on any cluster

@savitaashture
Copy link
Contributor Author

This looks good.

I have `question, should make the TektonTrigger reconciler respont to only on reosurce name(eg:

operator/pkg/reconciler/tektonpipeline/tektonpipeline.go

Line 96 in 7deb4ca

if tp.GetName() != watchedResourceName {

)
That will make sure that only one instance of triggers is installed on any cluster

ya that also make sense

I din't add name check to avoid hard rule

But yes i will add that change 👍

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Sep 22, 2020 •
edited
Loading

I din't add name check to avoid hard rule

i appreciate it.
But let us keep the hard rule at present.
Let us discuss this more in a work group meeting before we make an official release. :)

vdemeester
vdemeester reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two small comments.

pkg/reconciler/tektontrigger/tektontrigger.go
Comment on lines +98 to +113
//find the valid tekton-pipeline installation
if _, err := common.PipelineReady(r.pipelineInformer); err != nil {
if err.Error() == common.PipelineNotReady {
tt.Status.MarkDependencyInstalling("tekton-pipelines is still installing")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this refer to tekton-trigger instead of tekton-pipeline ? 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be tekton-pipelines because we are making sure pipelines should be running before we start installing triggers.

So for triggers pipeline is the dependency and when its not ready we can add a message on triggers status that pipeline is still installing

WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see, sounds good 👍

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/common.go Do not exist 0.0%

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@nikhil-thomas
Copy link
Member

/lgtm

@vdemeester
Copy link
Member

/approve
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@tekton-robot tekton-robot merged commit 81ede40 into tektoncd:main Sep 25, 2020
@nikhil-thomas nikhil-thomas mentioned this pull request Dec 17, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@vincent-pli vincent-pli Awaiting requested review from vincent-pli

Assignees

@vdemeester vdemeester

@nikhil-thomas nikhil-thomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @tekton-robot @nikhil-thomas @vdemeester