Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Metrics for TektonChains #1598

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jun 26, 2023

Added Metrics chains_reconciled which tells us what type of storage, signer and format is being used during the installation of the chain.
This can be use for telemetry

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Metrics `chains_reconciled` added which has {oci/pipelinerun/taskrun}_{storage/format/signer} information as metrics tags.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 26, 2023
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 26, 2023
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 26, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jun 26, 2023
@khrm
Copy link
Contributor Author

khrm commented Jun 26, 2023

/assign @jkandasa

@khrm khrm force-pushed the chainsMetrics branch 2 times, most recently from a0f7456 to f70455f Compare September 4, 2023 05:57
Added Metrics `chains_reconciled` which tells us
what type of storage, signer and format is being
used during chains installation.
This metrics is use for telemetry.
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@jkandasa jkandasa mentioned this pull request Sep 4, 2023
4 tasks
@piyush-garg
Copy link
Contributor

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@tekton-robot tekton-robot merged commit a05c420 into tektoncd:main Sep 4, 2023
@khrm khrm mentioned this pull request Sep 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants