Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor codebase to add e2e tests #165

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

nikhil-thomas
Copy link
Member

@nikhil-thomas nikhil-thomas commented Nov 10, 2020

Changes

Quick Review Links


Bump k8s version to v0.18.8

Regenerate clients to reflect k8s version bump

Modify code with respect to k8s and client changes

Update and vendor dependencies for e2e tests setup

Vendor k8s v0.18.8 packages

Vendor knative.dev/pkg/test

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Vendor k8s v0.18.8 packages

Vendor knative.dev/pkg/test

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2020
@nikhil-thomas nikhil-thomas requested review from savitaashture and removed request for sthaha November 10, 2020 07:48
Bump k8s version to v0.18.8

Regenerate clients to reflect k8s version bump

Modify code with respect to k8s and client changes

Add working e2e test base with a dummy test

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@tekton-robot tekton-robot merged commit 88ee269 into tektoncd:main Nov 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants