-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor codebase to add e2e tests #165
Conversation
Vendor k8s v0.18.8 packages Vendor knative.dev/pkg/test Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Bump k8s version to v0.18.8 Regenerate clients to reflect k8s version bump Modify code with respect to k8s and client changes Add working e2e test base with a dummy test Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
33db7ce
to
724fa64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Quick Review Links
Bump k8s version to v0.18.8
Regenerate clients to reflect k8s version bump
Modify code with respect to k8s and client changes
Update and vendor dependencies for e2e tests setup
Vendor k8s v0.18.8 packages
Vendor knative.dev/pkg/test
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes