Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable TektonResults access by system:authenticated user #1680

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 7, 2023

EndUser and UI require access to TektonResult because end-user/UI needs to know properties in TektonResult.

Fix #1679

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 7, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2023
@khrm
Copy link
Contributor Author

khrm commented Sep 7, 2023

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2023
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@khrm khrm changed the title Enable TektonResults access by system authenticated user Enable TektonResults access by system:authenticated user Sep 7, 2023
@piyush-garg
Copy link
Contributor

this should not be part of config. this should be part of result reconciler

@piyush-garg
Copy link
Contributor

or may be part of results itself, through aggregate view role

@khrm
Copy link
Contributor Author

khrm commented Sep 8, 2023

@piyush-garg It can't be part of the results because tektonresults.operator.tekton.dev is part of the operator. We also have tektonconfig clusterrolerole and bindings for authenticated users. So it make sense to add this also.

EndUser and UI requires access to TektonResult because enduser/UI need
to know properties in TektonResult.
@khrm
Copy link
Contributor Author

khrm commented Sep 8, 2023

How can we make it part of the results reconciler? This is more of a config think according to me.

@piyush-garg
Copy link
Contributor

How can we make it part of the results reconciler? This is more of a config think according to me.

aah ohk, i read it wrongly. i thought it is crd related to results component

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@tekton-robot tekton-robot merged commit 49be527 into tektoncd:main Sep 8, 2023
@khrm khrm deleted the results-cr-auth branch September 11, 2023 08:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to TektonResult CR for authenticated User
5 participants