-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enable TektonResults access by system:authenticated user #1680
Conversation
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @vdemeester @jkandasa
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this should not be part of config. this should be part of result reconciler |
or may be part of results itself, through aggregate view role |
@piyush-garg It can't be part of the results because |
EndUser and UI requires access to TektonResult because enduser/UI need to know properties in TektonResult.
10c598a
to
a097014
Compare
How can we make it part of the results reconciler? This is more of a config think according to me. |
aah ohk, i read it wrongly. i thought it is crd related to results component |
/lgtm |
EndUser and UI require access to TektonResult because end-user/UI needs to know properties in TektonResult.
Fix #1679
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes