Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add some reviewers (main branch) #177

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 24, 2020

Changes

Adding the following contributors to reviewers as they are actively
working in that branch.

  • pradeepitm12
  • savitaashture

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc
/cc @nikhil-thomas @savitaashture @pradeepitm12

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Adding the following contributors to reviewers as they are actively
working in that branch.

- pradeepitm12
- savitaashture

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Nov 24, 2020
@tekton-robot
Copy link
Contributor

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: savitaashture, pradeepitm12.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

Adding the following contributors to reviewers as they are actively
working in that branch.

  • pradeepitm12
  • savitaashture

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc
/cc @nikhil-thomas @savitaashture @pradeepitm12

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2020
@nikhil-thomas
Copy link
Member

/approve
/lgtm
/meow

@tekton-robot
Copy link
Contributor

@nikhil-thomas: cat image

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@tekton-robot tekton-robot merged commit 0a54096 into tektoncd:main Nov 25, 2020
@vdemeester vdemeester deleted the add-reviewers branch November 25, 2020 06:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants