Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Propagate proxy configuration to underlying deployments #184

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Propagate proxy configuration to underlying deployments #184

merged 1 commit into from
Dec 11, 2020

Conversation

vdemeester
Copy link
Member

Changes

This propagate any proxy configuration set on the operator
deployment (through environment variables). This applies to any
deployment managed by the different addons (TektonPipeline, …).

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind feature
/hold

/cc @nikhil-thomas @piyush-garg @savitaashture

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Propagate proxy configuration that are set on the operator to underlying deployments

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 8, 2020
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2020
@tekton-robot
Copy link
Contributor

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: piyush-garg, savitaashture.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

This propagate any proxy configuration set on the operator
deployment (through environment variables). This applies to any
deployment managed by the different addons (TektonPipeline, …).

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind feature
/hold

/cc @nikhil-thomas @piyush-garg @savitaashture

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Propagate proxy configuration that are set on the operator to underlying deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2020
@vdemeester
Copy link
Member Author

On hold because it needs a proper test / e2e test somehow 🙃

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go Do not exist 73.1%

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@nikhil-thomas
Copy link
Member

@savitaashture

savitaashture
savitaashture reviewed Dec 9, 2020
View reviewed changes
pkg/reconciler/common/proxy_test.go
t.Fatal(err)
}

assert.DeepEqual(t, actual, expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit confused with testcase here
As we have not set env in actual how are we getting actual and expected as equal ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ApplyProxySettings does its job 😉 — aka ready the proxy env variable (set by env.PatchAll) and add them to the list of environment variables.

@vdemeester vdemeester force-pushed the propagate-proxy-to-deployment branch from 4861de9 to a53d5cd Compare December 9, 2020 09:58
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go Do not exist 80.0%

@savitaashture
Copy link
Contributor

/test pull-tekton-operator-integration-tests

@vdemeester
Copy link
Member Author

Note: custom ca support will be a follow up 😉

@vdemeester
Copy link
Member Author

/hold cancel
/retest

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@vdemeester
Copy link
Member Author

Oh the error is legit… panic: interface conversion: interface {} is nil, not string 😅

@vdemeester
Propagate proxy configuration to underlying deployment
a42e6a6 
This propagate any proxy configuration set on the operator
deployment (through environment variables). This applies to any
deployment managed by the different addons (TektonPipeline, …).

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester force-pushed the propagate-proxy-to-deployment branch from a53d5cd to a42e6a6 Compare December 11, 2020 13:40
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go Do not exist 82.2%

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@vdemeester
Copy link
Member Author

/retest

1 similar comment
@vdemeester
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 9ff023b into tektoncd:main Dec 11, 2020
@vdemeester vdemeester deleted the propagate-proxy-to-deployment branch December 11, 2020 16:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@savitaashture savitaashture savitaashture left review comments

@piyush-garg piyush-garg piyush-garg left review comments

Assignees

@nikhil-thomas nikhil-thomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @tekton-robot @nikhil-thomas @savitaashture @piyush-garg