Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

config: update CRD to apiextensions.k8s.io/v1 #195

Merged
merged 1 commit into from
Dec 15, 2020
Merged

config: update CRD to apiextensions.k8s.io/v1 #195

merged 1 commit into from
Dec 15, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 15, 2020 •
edited
Loading

Changes

It will be deprecated soon 🙃

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Bump CRD definition to apiextensions.k8s.io/v1

@vdemeester
config: update CRD to apiextensions.k8s.io/v1
66b8e04 
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 15, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 15, 2020
savitaashture
savitaashture approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
sbose78
sbose78 approved these changes Dec 15, 2020
View reviewed changes
Copy link

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooner than later :)

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, savitaashture, sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@tekton-robot tekton-robot merged commit ed6aaa4 into tektoncd:main Dec 15, 2020
@vdemeester vdemeester deleted the ext-v1beta1-to-v1 branch December 16, 2020 06:16
@vdemeester vdemeester mentioned this pull request Feb 11, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sbose78 sbose78 sbose78 approved these changes

@savitaashture savitaashture savitaashture approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @nikhil-thomas @tekton-robot @sbose78 @savitaashture