Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add permission to consolequickstarts #203

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add permission to consolequickstarts #203

merged 1 commit into from
Jan 5, 2021

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Jan 5, 2021 •
edited
Loading

Changes

  • Added permission for consolequickstarts
    otherwise TektonAddon CR fails with below error
message: 'Install failed with message: consolequickstarts.console.openshift.io is forbidden: User "system:serviceaccount:openshift-operators:tekton-operator" cannot create resource "consolequickstarts" in API group "console.openshift.io" at the cluster scope'
  • Removed resources related to openshift from kubernetes roles

/cc @vdemeester @nikhil-thomas @pradeepitm12

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 5, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2021
@savitaashture savitaashture changed the title Add permission for consolequickstarts Add permission to consolequickstarts Jan 5, 2021
@savitaashture
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@tekton-robot tekton-robot merged commit ca804b3 into tektoncd:main Jan 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@nikhil-thomas nikhil-thomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @tekton-robot @nikhil-thomas @vdemeester