Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix label not getting added on namespace #228

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix label not getting added on namespace #228

merged 1 commit into from
Feb 1, 2021

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Feb 1, 2021 •
edited
Loading

This will fix the issue of label not getting
added on namespace

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 1, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go 68.5% 83.6% 15.1

@piyush-garg
Fix label not getting added on namespace
64b0083 
This will fix the issue of label not getting
added on namespace
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go 68.5% 83.6% 15.1

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/proxy.go 68.5% 83.6% 15.1

@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
vdemeester
vdemeester approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@tekton-robot tekton-robot merged commit 65f9255 into tektoncd:main Feb 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@vdemeester vdemeester

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piyush-garg @tekton-robot @savitaashture @vdemeester