[OpenShift] Fix metrics display issue

[savitaashture]

Changes

Issue: Metrics are not visible on Openshift Console

RootCause: ServiceMonitor role binding uses SA from openshift-monitoring namespace and to avoid overriding of that ns we used annotation operator.tekton.dev/preserve-rb-subject-namespace to preserve openshift-monitoring ns
But in Transform function we are doing transformation on single manifest and because of that logic of preserving namespace is not working in case of RoleBinding

Changes: As of now modified Transform function to do transformation on 2 different manifest one for RoleBinding and another for remaining resources.

Note: Will do refactoring in another PR so that openshift specific changes can be avoided as part of common

/cc @vdemeester @khrm @pradeepitm12 @nikhil-thomas @piyush-garg

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

[tekton-robot]

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: khrm, piyush-garg.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

Issue: Metrics are not visible on Openshift Console

RootCause: ServiceMonitor role binding uses SA from openshift-monitoring namespace and to avoid overriding of that ns we used annotation operator.tekton.dev/preserve-rb-subject-namespace to preserve openshift-monitoring ns
But in Transform function we are doing transformation on single manifest and because of that logic of preserving namespace is not working in case of RoleBinding

Changes: As of now modified Transform function to do transformation on 2 different manifest one for RoleBinding and another for remaining resources.

Note: Will do refactoring in another PR so that openshift specific changes can be avoided as part of common

/cc @vdemeester @khrm @pradeepitm12 @nikhil-thomas @piyush-garg

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformers.go	71.9%	64.5%	-7.4

[pradeepitm12]

Thank You
/lgtm

[vdemeester]

/meow

[tekton-robot]

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment