Add option to run tests on non-Intel architectures #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this moment tests for operator can be executed with default e2e-tests.sh script only for amd64 architecture, because operator image duringng setup process is built for amd64 by default. Addition of the PLATFORM variable to Makefile allows to build operator image for needed architecture via --platform parameter in ko tool. In case if PLATFORM variable is not specified, there will be current behaviour. Also --kubeconfig parameter support is added to the test script, this parameter is used when tests are executed not on default k8s cluster. If KUBECONFIG env variable is not specified, --kubeconfig parameter is not used. Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
vdemeester
approved these changes
Mar 2, 2021
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
At this moment tests for operator can be executed with default
e2e-tests.shscript only for amd64 architecture, because operator image during setup process is built for amd64 by default. Addition of the PLATFORM env variable to Makefile allows to build operator image for needed architecture via--platformparameter in ko tool.In case if PLATFORM variable is not specified, there will be current behaviour.
Also
--kubeconfigparameter support is added to the test script, this parameter is used when tests are executed not on default k8s cluster.If KUBECONFIG env variable is not specified,
--kubeconfigparameter is not used.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes