Fix EventListener instance deletion #339
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
The following is the coverage report on the affected files.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
Separate deletion of deployments from the deletion of all other resources. So that delete call to CRDs are executed first before calling delete on controllers. This will help to create a window before controller deletion, where controller can handle finalizers on CRDs and CRD instances. This is not the perfect fix, but this is good enough. Ideal fix will be to add finalizer on controllers and remove them after making sure all other resources have been removed. But this could create other issues such as the CRDs watched by controllers being deleted can cause the controllers t Signed-off-by: Nikhil Thomas <nikthoma@redhat.com> (cherry picked from commit 962c5bf)
Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
fix/eventlistener-uninstall
branch
from
d508541 to
3201f65
Compare
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Separate deletion of deployments from the deletion of all other resources.
So that delete call to CRDs are executed first before calling delete on controllers.
This will help to create a window before controller deletion, where controller can
handle finalizers on CRDs and CRD instances.
This is not the perfect fix, but this is good enough.
Ideal fix will be to add finalizer on controllers and remove them after making sure
all other resources have been removed. But this could create other issues such as the
CRDs watched by controllers being deleted can cause the controllers t
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
(cherry picked from commit 962c5bf)
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes