Move update spec calls to the end of reconciler #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would resolve some of the flakiness used to occur while installing Operator. Because of updating the object in the middle of reconciler, sometime used to get error ` the object has been modified; please apply your changes to the latest version and try again ` so this moves the update spec call to the end of reconciler. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
tekton-robot
requested review from
nikhil-thomas,
savitaashture and
vdemeester
vdemeester
approved these changes
Nov 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would resolve some of the flakiness used to occur
while installing Operator. Because of updating the object
in the middle of reconciler, sometime used to get error
the object has been modified; please apply your changes to the latest version and try againso this moves the update spec call to the end of reconciler.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes