Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Moves installerSet keys at one place & cleanup #547

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Moves installerSet keys at one place & cleanup #547

merged 1 commit into from
Dec 8, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Dec 8, 2021 •
edited
Loading

This moves the keys for installerSet and single place instead of
having in each package. Also cleanups duplicate code.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

/cc @savitaashture @nikhil-thomas

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2021
@sm43
Copy link
Member Author

sm43 commented Dec 8, 2021

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 8, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/utils.go 87.5% 90.0% 2.5

@sm43 sm43 force-pushed the keep-const-at-one-place branch from f2ad5ac to 8b6ddd4 Compare December 8, 2021 08:00
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/utils.go 87.5% 90.0% 2.5

@sm43 sm43 force-pushed the keep-const-at-one-place branch from 8b6ddd4 to 25054c7 Compare December 8, 2021 08:09
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/utils.go 87.5% 90.0% 2.5

@nikhil-thomas
Copy link
Member

/approve
✔️ lgtm

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
Moves installerSet keys at one place & cleanup
9f98d73 
This moves the keys for installerSet and single place instead of
having in each package. Also cleanups duplicate code.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the keep-const-at-one-place branch from 25054c7 to 9f98d73 Compare December 8, 2021 10:52
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/utils.go 87.5% 90.0% 2.5

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nikhil-thomas,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@tekton-robot tekton-robot merged commit b7d4e2d into tektoncd:main Dec 8, 2021
@sm43 sm43 deleted the keep-const-at-one-place branch December 8, 2021 11:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sm43 @tekton-robot @nikhil-thomas @vdemeester