Modification to enable OpenShift builds with releases #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
Remove version number from addon directory in kodata (openshift) Add a Check in Component e2e tests to make sure that instance of TektonConfig is not there before starting tests. If the TektonConfig is present delete tests on TektonPipeline, TektonAddon etc fails as the TektonConfig reconciler will bring it back immediately. Note: without this patch the e2e tests fail when run without running TektonConfig e2e first. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
add/openshift-builds
branch
from
a9e1ad1 to
afdd46b
Compare
|
This is awesome 💟 |
|
/lgtm |
vdemeester
approved these changes
Dec 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove version number from addon directory in kodata (openshift)
Add a Check in Component e2e tests to make sure that instance of
TektonConfig is not there before starting tests.
If the TektonConfig is present, delete tests on TektonPipeline, TektonAddon etc fails as the
TektonConfig reconciler will bring it back immediately. Note: without
this patch the e2e tests fail when run without running TektonConfig e2e
first.
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes