Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix flaky test behavior #616

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Fix flaky test behavior #616

merged 1 commit into from
Feb 5, 2022

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Feb 4, 2022 •
edited
Loading

Changes

  1. Golang maps are unordered and as part of this test we are checking output so there is 50% of chance for this test failure.
  2. The intend of test is to verify string output for the given labelselector so removed second map value.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 4, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2022
@savitaashture savitaashture requested a review from sm43 February 4, 2022 14:54
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@concaf
Copy link
Contributor

concaf commented Feb 5, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: concaf, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 08b4538 into tektoncd:main Feb 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@concaf concaf concaf approved these changes

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@sm43 sm43 Awaiting requested review from sm43

Assignees

@concaf concaf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @concaf @tekton-robot @vdemeester