Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update tektoncd/results to 0.4.0 #619

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 7, 2022

Changes

Update to the latest version of results.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Bump tektoncd/results to 0.4.0

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 7, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2022
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@@ -33,7 +33,7 @@ KO = $(or ${KO_BIN},${KO_BIN},$(BIN)/ko)
TEKTON_PIPELINE_VERSION ?= latest
TEKTON_TRIGGERS_VERSION ?= latest
TEKTON_DASHBOARD_VERSION ?= latest
TEKTON_RESULTS_VERSION ?= v0.3.1 # latest returns an older version hence hard coding to v0.3.1 for now (tektoncd/results#138)
TEKTON_RESULTS_VERSION ?= v0.4.0 # latest returns an older version hence hard coding to v0.3.1 for now (tektoncd/results#138)
Copy link
Contributor

@concaf concaf Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TEKTON_RESULTS_VERSION ?= v0.4.0 # latest returns an older version hence hard coding to v0.3.1 for now (tektoncd/results#138)
TEKTON_RESULTS_VERSION ?= v0.4.0 # tektoncd/results does not support the "latest" tag, so we resort to hardcoding the latest version periodically

@@ -1,4 +1,4 @@
export TEKTON_PIPELINE_VERSION=latest
export TEKTON_TRIGGERS_VERSION=latest
export TEKTON_RESULTS_VERSION=v0.3.1
export TEKTON_RESULTS_VERSION=v0.4.0
Copy link
Contributor

@concaf concaf Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export TEKTON_RESULTS_VERSION=v0.4.0
# tektoncd/results does not support the "latest" tag, so we resort to hardcoding the latest version periodically
export TEKTON_RESULTS_VERSION=v0.4.0

@tekton-robot tekton-robot merged commit 2b69492 into tektoncd:main Feb 8, 2022
@vdemeester vdemeester deleted the update-results branch February 8, 2022 09:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants