Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OpenShift] Refactors TektonAddon reconciler #632

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Feb 24, 2022

This refactors addon reconciler and moves all components to individual
file rather than keeping everything at single place to improve
readability.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

This refactors addon reconciler and moves all components to individual
file rather than keeping everything at single place to improve
readability.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 24, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 24, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go Do not exist 0.0%
pkg/reconciler/openshift/tektonaddon/clustertTaskVersioned.go Do not exist 0.0%
pkg/reconciler/openshift/tektonaddon/installerset.go Do not exist 0.0%
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go Do not exist 0.0%
pkg/reconciler/openshift/tektonaddon/pipelinetemplate.go Do not exist 0.0%
pkg/reconciler/openshift/tektonaddon/triggers.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@tekton-robot tekton-robot merged commit ab44542 into tektoncd:main Feb 28, 2022
@sm43 sm43 deleted the addon-refactor branch August 19, 2022 05:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants