Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ServiceMonitor for Triggers metrics #635

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Add ServiceMonitor for Triggers metrics #635

merged 1 commit into from
Mar 1, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 28, 2022 •
edited
Loading

Adding ServiceMonitor for Triggers. We have metrics available in Triggers v0.19.0

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@khrm
Add ServiceMonitor for Triggers metrics
8cb7a51 
Adding ServiceMonitor for Triggers. We have metrics available in
Triggers v0.19.0
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 28, 2022
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 28, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@khrm khrm changed the title WEP: Add ServiceMonitor for Triggers metrics Add ServiceMonitor for Triggers metrics Mar 1, 2022
@khrm
Copy link
Contributor Author

khrm commented Mar 1, 2022

/test pull-tekton-operator-integration-tests

@vdemeester vdemeester closed this Mar 1, 2022
@vdemeester vdemeester reopened this Mar 1, 2022
savitaashture
savitaashture reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@khrm
Copy link
Contributor Author

khrm commented Mar 1, 2022

/test pull-tekton-operator-integration-tests

@tekton-robot tekton-robot merged commit 6834830 into tektoncd:main Mar 1, 2022
@khrm khrm deleted the triggersSM branch June 7, 2023 12:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @vdemeester @savitaashture