Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[release-v0.42.x] picking up latest changes in knative 1.8 #6202

Merged
merged 1 commit into from
Mar 3, 2023
Merged

[release-v0.42.x] picking up latest changes in knative 1.8 #6202

merged 1 commit into from
Mar 3, 2023

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Feb 22, 2023 •
edited
Loading

Changes

This PR is a result of:

go get knative.dev/pkg@release-1.8
./hack/update-codegen.sh

knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that Pipelines 0.42.x can take advantage of this performance improvement.

The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR #6062.
We have another PR #6194 open to update pipeline controllers in the main branch.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bring the latest performance fix in knative/pkg which helps reduce CPU/Memory usage for huge pipelines.

@pritidesai
picking up latest changes in knative 1.8
3d80ace 
knative.dev/pkg was recently updated to include a performance fix which helped
reduced the CPU usage by 61% and memory usage by 44% for huge pipelines.
This commit is updating the tekton controllers to include that fix such that
Pipelines 0.42.x can take advantage of this performance improvement.

The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was
updated to use knative 1.9 post 0.45 in PR tektoncd#6062.
We have another PR tektoncd#6194 open to update pipeline controllers in the main branch.

Signed-off-by: pritidesai <pdesai@us.ibm.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 22, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/retest
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@lbernick
Copy link
Member

/retest
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

/test pull-tekton-pipeline-beta-integration-tests

This was referenced Feb 23, 2023
Merged
Closed
Closed
@pritidesai
Copy link
Member Author

/retest

1 similar comment
@pritidesai
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 8a3467d into tektoncd:release-v0.42.x Mar 3, 2023
@pritidesai pritidesai deleted the bring-latest-knative-1.8-to-42 branch March 3, 2023 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lbernick lbernick Awaiting requested review from lbernick

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pritidesai @vdemeester @tekton-robot @lbernick