Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release-v0.41.x] Fix spammy logs #6787

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jun 7, 2023

Cherry-pick of e4435e9.

A couple of lines are causing a lot of spam in the controller logs:

  • logging the content of steps
  • logging that the cache client cannot be find, which is expected since the cache is only available in the Run/CustomRun controller and not for TaskRun and PipelineRun controllers

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • n/a Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

bug fix: reduce log spam

A couple of lines are causing a lot of spam in the controller logs:
- logging the content of steps
- logging that the cache client cannot be find, which is expected
  since the cache is only available in the Run/CustomRun controller
  and not for TaskRun and PipelineRun controllers

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 7, 2023
@tekton-robot tekton-robot requested review from abayer and afrittoli June 7, 2023 18:41
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2023
@lbernick lbernick mentioned this pull request Jun 7, 2023
7 tasks
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go 84.9% 88.4% 3.5
pkg/reconciler/taskrun/taskrun.go 84.7% 81.3% -3.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go 84.9% 88.4% 3.5
pkg/reconciler/taskrun/taskrun.go 84.7% 81.3% -3.4

@lbernick lbernick changed the title Cherry-pick: Fix spammy logs [release-v0.41.x] Fix spammy logs Jun 7, 2023
@vdemeester
Copy link
Member

I'll do the same as the other PR.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go 84.9% 88.4% 3.5
pkg/reconciler/taskrun/taskrun.go 84.7% 81.3% -3.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go 84.9% 88.4% 3.5
pkg/reconciler/taskrun/taskrun.go 84.7% 81.3% -3.4

@vdemeester
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@tekton-robot tekton-robot merged commit 89c2789 into tektoncd:release-v0.41.x Jun 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants