Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

TEP-0115: Update git resolver doc to use "revision" and "pathInRepo" fields #76

Conversation

QuanZhang-William
Copy link
Member

Part of TEP-0115

Update Git Resolver documentation to use "revision" and "pathInRepo" fields to reflect the changes in TEP-0115: Add git revision resolution support in Git Resolver and Add core Reconciler testing and fake resolver framework functions

Part of TEP-0115
Update Git Resolver documentation to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution support in Git Resolver](tektoncd#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd#51)
@tekton-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@tekton-robot tekton-robot requested review from dibyom and a user August 8, 2022 20:51
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 8, 2022
@QuanZhang-William QuanZhang-William marked this pull request as ready for review August 8, 2022 20:51
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@QuanZhang-William
Copy link
Member Author

/assign @jerop

@QuanZhang-William QuanZhang-William changed the title Update git resolver doc to use "revision" and "pathInRepo" fields TEP-0115: Update git resolver doc to use "revision" and "pathInRepo" fields Aug 8, 2022
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibyom
Copy link
Member

dibyom commented Aug 8, 2022

/cc @abayer

@tekton-robot tekton-robot requested a review from abayer August 8, 2022 21:23
@abayer
Copy link
Contributor

abayer commented Aug 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@jerop
Copy link
Member

jerop commented Aug 8, 2022

@abayer I'm not an owner in this repo so can't approve, switch places? 😂

/lgtm

@abayer
Copy link
Contributor

abayer commented Aug 8, 2022

/approve

=)

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@tekton-robot tekton-robot merged commit 0a7a4cd into tektoncd:main Aug 8, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants