Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update CEL GO to v0.9.0 and CEL Spec to v0.6.0 #1322

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Mar 1, 2022

Update CEL GO to v0.9.0 for fixing bugs and improving cel performance.
https://github.com/google/cel-go/releases/tag/v0.9.0
https://github.com/google/cel-go/releases/tag/v0.8.0

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 1, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 1, 2022
@khrm khrm added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 1, 2022
@khrm
Copy link
Contributor Author

khrm commented Mar 1, 2022

/test pull-tekton-triggers-integration-tests

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@dibyom
Copy link
Member

dibyom commented Mar 3, 2022

Any breaking changes in CEL to be aware of? Also, can we call this out in the release notes section?

@TristonianJones
Copy link
Contributor

TristonianJones commented Mar 25, 2022

There have been some substantial improvements and changes to CEL even since 0.9.0. I was about to publish the following pull request and saw this one:
main...TristonianJones:cel-upgrade

@dibyom The biggest change in v0.10.* and beyond is support for heterogeneous equality which should improve
the ease of use for working with JSON data as it will finally support the following expressions without an error:
json.field != null. Additionally, there have been some pretty substantial improvements to the CEL environment
bootstrapping and evaluation paths when working with lists.

@dibyom
Copy link
Member

dibyom commented Mar 29, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@tekton-robot tekton-robot merged commit f57f629 into tektoncd:main Mar 29, 2022
@khrm khrm deleted the celUpdate branch February 28, 2023 04:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants